lkml.org 
[lkml]   [2014]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] kernel/workqueue.c: pr_warning/pr_warn & printk/pr_info
From
Date
On Mon, 2014-05-12 at 20:26 +0200, Fabian Frederick wrote:
> On Mon, 12 May 2014 11:21:28 -0700 Joe Perches <joe@perches.com> wrote:
> > On Mon, 2014-05-12 at 19:56 +0200, Fabian Frederick wrote:
[]
> > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c
[]
> > > @@ -4548,7 +4548,7 @@ void print_worker_info(const char *log_lvl, struct task_struct *task)
> > > probe_kernel_read(desc, worker->desc, sizeof(desc) - 1);
> > >
> > > if (fn || name[0] || desc[0]) {
> > > - printk("%sWorkqueue: %s %pf", log_lvl, name, fn);
> > > + pr_info("%sWorkqueue: %s %pf", log_lvl, name, fn);
> >
> > Not correct.
> >
> > log_lvl already emits the appropriate level
> > and this overrides it with KERN_INFO.
> >
> > The output will now be incorrect emitting
> > at KERN_INFO followed by an SOH and the
> > desired log level.
>
> Such printk can't be converted to pr_ ?

Correct.




\
 
 \ /
  Last update: 2014-05-12 21:21    [W:0.040 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site