lkml.org 
[lkml]   [2014]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: remap_file_pages: initialize populate before usage
On Mon, May 12, 2014 at 08:40:54AM -0400, Sasha Levin wrote:
> 'populate' wasn't initialized before being used in error paths,
> causing panics when mm_populate() would get called with invalid
> values.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

> ---
> mm/mmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 84dcfc7..2a0e0a8 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2591,7 +2591,7 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
>
> struct mm_struct *mm = current->mm;
> struct vm_area_struct *vma;
> - unsigned long populate;
> + unsigned long populate = 0;
> unsigned long ret = -EINVAL;
>
> pr_warn_once("%s (%d) uses deprecated remap_file_pages() syscall. "
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2014-05-12 20:21    [W:0.029 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site