Messages in this thread | | | Date | Mon, 12 May 2014 17:20:15 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH] memcg: deprecate memory.force_empty knob |
| |
On Mon 12-05-14 11:00:14, Tejun Heo wrote: > On Mon, May 12, 2014 at 04:58:03PM +0200, Michal Hocko wrote: > > @@ -4793,6 +4793,10 @@ static int mem_cgroup_force_empty_write(struct cgroup_subsys_state *css, > > > > if (mem_cgroup_is_root(memcg)) > > return -EINVAL; > > + pr_info("%s (%d): memory.force_empty is deprecated and will be removed.", > > + current->comm, task_pid_nr(current)); > > + pr_cont(" Let us know if you know if it needed in your usecase at"); > > + pr_cont(" linux-mm@kvack.org\n"); > > return mem_cgroup_force_empty(memcg); > > It probably would be way easier to just mark the knob with > CFTYPE_INSANE.
That would prevent from creating the file, right? I do not mind that but I would like to see people complaining before.
-- Michal Hocko SUSE Labs
| |