lkml.org 
[lkml]   [2014]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 134/143] KVM: Improve create VCPU parameter (CVE-2013-4587)
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andy Honig <ahonig@google.com>

    commit 338c7dbadd2671189cec7faf64c84d01071b3f96 upstream

    In multiple functions the vcpu_id is used as an offset into a bitfield. Ag
    malicious user could specify a vcpu_id greater than 255 in order to set or
    clear bits in kernel memory. This could be used to elevate priveges in the
    kernel. This patch verifies that the vcpu_id provided is less than 255.
    The api documentation already specifies that the vcpu_id must be less than
    max_vcpus, but this is currently not checked.

    Reported-by: Andrew Honig <ahonig@google.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Andrew Honig <ahonig@google.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    virt/kvm/kvm_main.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
    index 82b6fdc..3b9443b 100644
    --- a/virt/kvm/kvm_main.c
    +++ b/virt/kvm/kvm_main.c
    @@ -1846,6 +1846,9 @@ static int kvm_vm_ioctl_create_vcpu(struct kvm *kvm, u32 id)
    int r;
    struct kvm_vcpu *vcpu, *v;

    + if (id >= KVM_MAX_VCPUS)
    + return -EINVAL;
    +
    vcpu = kvm_arch_vcpu_create(kvm, id);
    if (IS_ERR(vcpu))
    return PTR_ERR(vcpu);
    --
    1.7.12.2.21.g234cd45.dirty




    \
     
     \ /
      Last update: 2014-05-12 04:21    [W:4.620 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site