lkml.org 
[lkml]   [2014]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] perf tools: Use tid for finding thread
Date
On Sun, 11 May 2014 15:15:42 +0200, Jiri Olsa wrote:
> On Wed, May 07, 2014 at 11:26:06AM +0900, Namhyung Kim wrote:
>> I believe that passing pid (instead of tid) as the 3rd arg of the
>> machine__find*_thread() was to find a main thread so that it can
>> search proper map group for symbols. However with the map sharing
>> patch applied, it now can do it in any thread.
>>
>> It fixes a bug when each thread has different name, it only reports a
>> main thread for samples in other threads.
>
> and breaks tests 14 and 26 ;-)
>
> ...
> 14: Test matching and linking multiple hists : FAILED!
> 15: Try 'use perf' in python, checking link problems : Ok
> 16: Test breakpoint overflow signal handler : Ok
> 17: Test breakpoint overflow sampling : Ok
> 18: Test number of exit event of a simple workload : Ok
> 19: Test software clock events have valid period values : Ok
> 20: Test converting perf time to TSC : Ok
> 21: Test object code reading : Ok
> 22: Test sample parsing : Ok
> 23: Test using a dummy software event to keep tracking : Ok
> 24: Test parsing with no sample_id_all bit set : Ok
> 25: Test dwarf unwind : Ok
> 26: Test filtering hist entries : FAILED!
> ...

Forgot to set sample->tid for those cases. Will fix.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2014-05-12 03:21    [W:0.185 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site