lkml.org 
[lkml]   [2014]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 06/22] [SCSI] mpt2sas: Dont disable device twice at suspend.
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tyler Stachecki <tstache1@binghamton.edu>

    commit af61e27c3f77c7623b5335590ae24b6a5c323e22 upstream.

    On suspend, _scsih_suspend calls mpt2sas_base_free_resources, which
    in turn calls pci_disable_device if the device is enabled prior to
    suspending. However, _scsih_suspend also calls pci_disable_device
    itself.

    Thus, in the event that the device is enabled prior to suspending,
    pci_disable_device will be called twice. This patch removes the
    duplicate call to pci_disable_device in _scsi_suspend as it is both
    unnecessary and results in a kernel oops.

    Signed-off-by: Tyler Stachecki <tstache1@binghamton.edu>
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/mpt2sas/mpt2sas_scsih.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
    +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
    @@ -8086,7 +8086,6 @@ _scsih_suspend(struct pci_dev *pdev, pm_

    mpt2sas_base_free_resources(ioc);
    pci_save_state(pdev);
    - pci_disable_device(pdev);
    pci_set_power_state(pdev, device_state);
    return 0;
    }



    \
     
     \ /
      Last update: 2014-05-11 23:21    [W:5.088 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site