lkml.org 
[lkml]   [2014]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap
    Date
    Using devm_ioremap_resource() API should actually be preferred over
    devm_ioremap(), since the former request the mem region first and then
    gives back the ioremap'ed memory pointer.
    devm_ioremap_resource() calls request_mem_region(), therby preventing
    other drivers to make any overlapping call to the same region.

    Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
    ---
    drivers/usb/host/ohci-exynos.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
    index 9cf80cb..aa64fb5 100644
    --- a/drivers/usb/host/ohci-exynos.c
    +++ b/drivers/usb/host/ohci-exynos.c
    @@ -120,9 +120,8 @@ skip_phy:

    hcd->rsrc_start = res->start;
    hcd->rsrc_len = resource_size(res);
    - hcd->regs = devm_ioremap(&pdev->dev, res->start, hcd->rsrc_len);
    + hcd->regs = devm_ioremap_resource(&pdev->dev, res);
    if (!hcd->regs) {
    - dev_err(&pdev->dev, "Failed to remap I/O memory\n");
    err = -ENOMEM;
    goto fail_io;
    }
    --
    1.7.10.4


    \
     
     \ /
      Last update: 2014-05-10 12:21    [W:4.044 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site