Messages in this thread | | | Subject | Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs | From | "Ivan T. Ivanov" <> | Date | Sat, 10 May 2014 11:06:49 +0300 |
| |
Hi Courtney,
On Fri, 2014-05-09 at 13:30 -0700, Courtney Cavin wrote:
> > > Requiring a specific PMIC listed before a generic one allows us an > > > escape hatch in the future if for some reason we need to add a quirk for > > > a specific PMIC. > > > > Is there a conclusion on this issue? I am voting for generic name :-) > > "qcom,pm-qpnp". > > Josh and I have discussed this offline, and I think we have come to the > conclusion that this should be a generic driver with only a generic > binding. The current proposed name is "spmi-ext", as there is specific > functional relation to Qualcomm, PMICs or QPNP. > > Further, the binding documentation should be specific to pm8[89]41 as > 'mfd/pm8x41.txt', and should contain the compatibles: > - "qcom,pm8941", "spmi-ext" > - "qcom,pm8841", "spmi-ext" > > This naming has been discussed to death, so a few more shed color > suggestions can't possibly hurt.
I am fine with this. Thanks.
> > > Further complication is that several sub function drivers expect to > > runtime detect the exact version of the controller ("qcom, qpnp-iadc", > > "qcom, qpnp-vadc", "qcom, qpnp-linear-charger"). This is realized by the > > exported function of the driver "qcom, qpnp-revid". Would it be good > > idea to merge qpnp-revid and "qcom,pm-qpnp" driver? > > Each block within the PMICs have--undocumented--version registers, so a > global version number is not particularly useful. A good example of > this is the ADC code [1], as you mentioned.
Do you happen to know how to match local subdevices revisions to global PMIC revision? Earlier mentioned drivers are using global chip revision.
I will not be surprised if local subdevice version is not changed, but instead global version is changed, when only subdevice functionality is changed ;-)
Regards, Ivan
| |