Messages in this thread | | | Date | Thu, 1 May 2014 10:53:07 -0700 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] regulator: s5m8767: Allow GPIO 0 to be used as external control |
| |
On Wed, Apr 30, 2014 at 10:40:41AM +0200, Krzysztof Kozlowski wrote: > GPIO 0 is a valid GPIO so allow using it as external control for > regulator.
Applied, thanks. This is only safe because we don't have any actual users of platform data - if we do have users of platform data then things get a bit more tricky since the expectation with platform data is that zero is the default/do nothing case.
Really if this is an issue it is better to fix things so that GPIO 0 doesn't get used for anything, with DT there's no need to do that since the numbers are all dynamic but it does get a little more tricky in the platform data case sadly. [unhandled content-type:application/pgp-signature] | |