lkml.org 
[lkml]   [2014]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] net: via-rhine: Fix compiler warning re: pointer casting on 64bit
Date
From: Alexey Charkov [mailto:alchark@gmail.com]
...
> This patch removes the cast altogether, and instead stores an actual
> pointer to u8 in match->data. All instances of 'revision' are also
> unified to u8 instead of an assortment of different integer types,
> in line with the definition of 'revision' in struct pci_dev.
...
> +static u8 vt8500_revision = 0x84;
> static struct of_device_id rhine_of_tbl[] = {
> - { .compatible = "via,vt8500-rhine", .data = (void *)0x84 },
> + { .compatible = "via,vt8500-rhine", .data = &vt8500_revision },
> { } /* terminate list */

Actually the above looks strange.
Why does the vt8500 have a revision number of 0x84 ?
Surely it should be 0x85, or even 0x8500 (or decimal 85000).

David

\
 
 \ /
  Last update: 2014-05-01 12:21    [W:0.143 / U:2.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site