lkml.org 
[lkml]   [2014]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 014/134] intel_idle: Check cpu_idle_get_driver() for NULL before dereferencing it.
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

    commit 3735d524da64b70b41c764359da36f88aded3610 upstream.

    If the machine is booted without any cpu_idle driver set
    (b/c disable_cpuidle() has been called) we should follow
    other users of cpu_idle API and check the return value
    for NULL before using it.

    Reported-and-tested-by: Mark van Dijk <mark@internecto.net>
    Suggested-by: Jan Beulich <JBeulich@suse.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    Cc: Daniel Kiper <daniel.kiper@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/idle/intel_idle.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/idle/intel_idle.c
    +++ b/drivers/idle/intel_idle.c
    @@ -594,8 +594,9 @@ static int __init intel_idle_init(void)
    intel_idle_cpuidle_driver_init();
    retval = cpuidle_register_driver(&intel_idle_driver);
    if (retval) {
    + struct cpuidle_driver *drv = cpuidle_get_driver();
    printk(KERN_DEBUG PREFIX "intel_idle yielding to %s",
    - cpuidle_get_driver()->name);
    + drv ? drv->name : "none");
    return retval;
    }




    \
     
     \ /
      Last update: 2014-04-10 10:41    [W:4.209 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site