lkml.org 
[lkml]   [2014]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 110/134] ALSA: pcsp: Fix the order of input device unregistration
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 6408eac2665955343cd0e4bcd7d6237ce39611ed upstream.

    The current code may access to the already freed object. The input
    device must be accessed and unregistered before freeing the top level
    sound object.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    [bwh: Backported to 3.2: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Cc: Weng Meiling <wengmeiling.weng@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/drivers/pcsp/pcsp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/drivers/pcsp/pcsp.c
    +++ b/sound/drivers/pcsp/pcsp.c
    @@ -187,8 +187,8 @@ static int __devinit pcsp_probe(struct p
    static int __devexit pcsp_remove(struct platform_device *dev)
    {
    struct snd_pcsp *chip = platform_get_drvdata(dev);
    - alsa_card_pcsp_exit(chip);
    pcspkr_input_remove(chip->input_dev);
    + alsa_card_pcsp_exit(chip);
    platform_set_drvdata(dev, NULL);
    return 0;
    }



    \
     
     \ /
      Last update: 2014-04-10 07:21    [W:4.101 / U:25.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site