lkml.org 
[lkml]   [2014]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 131/134] media: saa7164: fix return value check in saa7164_initdev()
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

    commit 89f4d45b2752df5d222b5f63919ce59e2d8afaf4 upstream.

    In case of error, the function kthread_run() returns ERR_PTR()
    and never returns NULL. The NULL test in the return value check
    should be replaced with IS_ERR().

    Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
    [bwh: Backported to 3.2: adjust filename]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Cc: Jianguo Wu <wujianguo@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/video/saa7164/saa7164-core.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/media/video/saa7164/saa7164-core.c
    +++ b/drivers/media/video/saa7164/saa7164-core.c
    @@ -1386,9 +1386,11 @@ static int __devinit saa7164_initdev(str
    if (fw_debug) {
    dev->kthread = kthread_run(saa7164_thread_function, dev,
    "saa7164 debug");
    - if (!dev->kthread)
    + if (IS_ERR(dev->kthread)) {
    + dev->kthread = NULL;
    printk(KERN_ERR "%s() Failed to create "
    "debug kernel thread\n", __func__);
    + }
    }

    } /* != BOARD_UNKNOWN */



    \
     
     \ /
      Last update: 2014-04-10 07:01    [W:4.024 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site