Messages in this thread |  | | Date | Wed, 9 Apr 2014 11:39:23 -0400 | From | Steven Rostedt <> | Subject | Re: nohz problem with idle time on old hardware |
| |
On Wed, 9 Apr 2014 11:31:43 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> > Hmm, looking at the code, I see it probably should still do the check. > > OK, nevermind ;-)
Reading even more of the code, now I'm totally confused :-)
When tick_setup_sched_timer() is called, if tick_nohz_enabled is set, then we set tick_nohz_active.
This gets called by hrtimer_switch_to_hres(), and before that is called, the tick_check_oneshot_changed() will never get to the tick_nohz_switch_to_nohz() call.
Looks to me, the real answer is to nuke both the if statement *and* the setting of the tick_nohz_active in that function. Both looks a bit redundant to me.
-- Steve
|  |