Messages in this thread | | | Date | Tue, 8 Apr 2014 10:33:43 +0100 | From | Javi Merino <> | Subject | Re: [PATCH v11 0/4] thermal: samsung: Clean up and add support for Exynos5420 |
| |
On Thu, Mar 20, 2014 at 02:45:54AM +0000, Naveen Krishna Ch wrote: > Hello Tomasz, > > On 20 March 2014 00:58, Tomasz Figa <t.figa@samsung.com> wrote: > > Hi Leela, > > > > > > On 19.03.2014 12:19, Leela Krishna Amudala wrote: > >> > >> Hi All, > >> > >> I didn't see this series in mainline, Any comments for this ? > > > > > > Naveen had posted v12 of this series and I believe all the patches got my > > Reviewed-by. > > > > Best regards, > > Tomasz > Thanks for your reply. > These patches are posted to the mailing list quite some time now. > Anything i can do to speed up the process.
These patches create 5 thermal zones, one for each sensor. Due to the way the exynos code in drivers/thermal/samsung/exynos_thermal_common.c registers thermal zones, each one gets a cpufreq_cooling_device. Therefore you end up with 5 thermal zone each of which is controlling the cpu frequency.
Wouldn't it be better to collate these 5 sensors to create one thermal zone for the whole SoC? Maybe a simplistic algorithm like reporting the maximum temperature of all the sensors as the thermal zone temperature is good enough.
Cheers, Javi
| |