Messages in this thread | | | Date | Tue, 08 Apr 2014 09:36:02 +0300 | From | Boaz Harrosh <> | Subject | Re: [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory |
| |
On 03/18/2014 10:51 PM, Matei Oprea wrote: > It's easier to use kcalloc for allocating arrays. While at it > also remove useless casting value. > > Signed-off-by: Matei Oprea <eu@opreamatei.ro> > Cc: ROSEdu Kernel Community <firefly@lists.rosedu.org> > --- > drivers/scsi/lpfc/lpfc_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 68c94cc..0a51ca5 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -4731,9 +4731,9 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba) > } > > if (!phba->sli.ring) > - phba->sli.ring = (struct lpfc_sli_ring *) > - kzalloc(LPFC_SLI3_MAX_RING * > + phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING, > sizeof(struct lpfc_sli_ring), GFP_KERNEL); > +
Just a nit please put this recheck inside the if(){} so in the hot path when phba->sli.ring is already allocated it will not test twice.
> if (!phba->sli.ring)
and unlikely() on this if
> return -ENOMEM; > >
thanks Boaz
| |