Messages in this thread | | | Subject | Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node | From | "Ivan T. Ivanov" <> | Date | Tue, 08 Apr 2014 16:46:45 +0300 |
| |
On Tue, 2014-04-08 at 07:33 -0500, Timur Tabi wrote: > Ivan T. Ivanov wrote: > >> >I'm confused by this. Isn't this information already defined in the > >> >pinctrl-msm8x74.c driver? > >> > > >> >static const char * const blsp_spi8_groups[] = { > >> > "gpio45", "gpio46", "gpio47", "gpio48" > >> >}; > > I am not sure that I understand the question. This is one of > > possible ways to describe relationship between pins and functions. > > As they are described is visible what is their real purpose. > > Ok, let me rephrase. > > The 8x74 pinctrl driver already contains this information. It already > defines a "blsp_spi8" group consisting of GPIOs 45, 46, 47, and 48. > > This patch adds that same exact information into the device tree. Why > are we duplicating that information? Why add it to the device tree when > it's already in the driver (and already working).
Probably. It was my natural way of thinking. Pin have a functions. It is easier if I measure signals to just look at the device tree file. What are you suggesting?
> > Also, I don't see any code anywhere that uses these new device tree nodes.
This is easy to fix :-).
Regards, Ivan
| |