lkml.org 
[lkml]   [2014]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] ptrace: Fix fork event messages across pid namespaces
On 04/02, Matthew Dempsky wrote:
>
> On Wed, Apr 2, 2014 at 2:58 PM, Matthew Dempsky <mdempsky@google.com> wrote:
> > Otherwise, it looks like (e.g.) the attempts to get the parent's pid
> > in fill_prstatus() and tomoyo_sys_getppid() are also theoretical races
> > of the same kind?
>
> Doh, nevermind, those functions would potentially be use null "struct
> pid" pointers, not "struct pid_namespace" pointers; and pid_nr_ns()
> guards against pid being null.

Yes, and they want the parent's pid, not ours pid in parent's namespace.

Hmm. In fact I am replying only because I am not sure fill_psinfo() is
correct, perhaps it confuses tid with tgid. I dunno.

Oleg.



\
 
 \ /
  Last update: 2014-04-07 21:41    [W:0.046 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site