Messages in this thread Patch in this message | | | From | Mel Gorman <> | Subject | [PATCH 3/3] mm: Allow FOLL_NUMA on FOLL_FORCE | Date | Mon, 7 Apr 2014 16:10:43 +0100 |
| |
As _PAGE_NUMA is no longer aliased to _PAGE_PROTNONE there should be no confusion between them. It should be possible to kick away the special casing in __get_user_pages.
Signed-off-by: Mel Gorman <mgorman@suse.de> --- mm/memory.c | 12 ------------ 1 file changed, 12 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c index 22dfa61..b9c35a7 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1714,18 +1714,6 @@ long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm, vm_flags &= (gup_flags & FOLL_FORCE) ? (VM_MAYREAD | VM_MAYWRITE) : (VM_READ | VM_WRITE); - /* - * If FOLL_FORCE and FOLL_NUMA are both set, handle_mm_fault - * would be called on PROT_NONE ranges. We must never invoke - * handle_mm_fault on PROT_NONE ranges or the NUMA hinting - * page faults would unprotect the PROT_NONE ranges if - * _PAGE_NUMA and _PAGE_PROTNONE are sharing the same pte/pmd - * bitflag. So to avoid that, don't set FOLL_NUMA if - * FOLL_FORCE is set. - */ - if (!(gup_flags & FOLL_FORCE)) - gup_flags |= FOLL_NUMA; - i = 0; do { -- 1.8.4.5
| |