lkml.org 
[lkml]   [2014]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: rtl8187se: Fix warning symbol should be static
From
Date
Am Montag, den 07.04.2014, 01:34 +0000 schrieb Stefan Lippers-Hollmann:
> Hi
>
> On Sunday 06 April 2014, Josh Triplett wrote:
> > On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> > > This patch solves some sparse warnings about "symbol [...] was not
> > > declared. Should it be static?" by including the correct header files.
> > >
> > > Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
> >
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> [...]
>
> Given that that rtl8187se support has already been merged mainline (for
> 3.15-rc1) into the existing rtl8180 (soon to be renamed to rtl818x)
> driver, wouldn't it make more sense to remove
> drivers/staging/rtl8187se/ rather than trying to fixing it?
>
> commit 1eba648f998ef9c31b8cf062754a4a7b4ab9001f
> Author: Andrea Merello <andrea.merello@gmail.com>
> Date: Wed Mar 26 21:04:23 2014 +0100
>
> rtl8180: enable rtl8187se support
>
> Finally make rtl8187se works (hopefylly).
> This patch adds PCI ID for rtl8187, updates copyright notes and
> updates MODULE_DESCRIPTION.
>
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> Regards
> Stefan Lippers-Hollmann

Yes, probably. Sorry, didn't know that, hadn't looked after this!



\
 
 \ /
  Last update: 2014-04-07 17:21    [W:0.024 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site