Messages in this thread | | | From | Raphael Geissert <> | Date | Mon, 7 Apr 2014 15:45:51 +0200 | Subject | Re: [PATCH 3.2 17/18] cifs: ensure that uncached writes handle unmapped areas correctly |
| |
Hi,
On 7 April 2014 03:41, Ben Hutchings <ben@decadent.org.uk> wrote: > On Mon, 2014-04-07 at 00:35 +0100, Ben Hutchings wrote: >> 3.2.57-rc1 review patch. If anyone has any objections, please let me know. > [...] > --- a/fs/cifs/file.c > +++ b/fs/cifs/file.c [...] > + /* > + * i + 1 now represents the number of pages we actually used in > + * the copy phase above. > + */ > + npages = min(npages, i + 1);
I'm having trouble understanding why min() is needed here. It shouldn't harm either, but I find it confusing.
Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net
| |