lkml.org 
[lkml]   [2014]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators
Date
On Monday 07 April 2014 14:32:20 Mike Looijmans wrote:
> On 04/07/2014 02:25 PM, Arnd Bergmann wrote:
>
> Judging from the kernel output, regulator_get_optional returns -ENODEV if the
> supply wasn't found.
>
> Maybe the API is confusing (or wrong?) here.
>
> If you change the code as per your suggestion, the SD will not work unless you
> explicitly assign supplies. And judging from what I've seen so far, I am the
> first to have ever attached a power supply to this controller...

It's certainly not very "optional" if it returns an error here.

You could try to special-case the "-ENODEV" return here, but I think it
would be better to change the regulator interface to be less confusing.

Arnd


\
 
 \ /
  Last update: 2014-04-07 15:21    [W:0.040 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site