lkml.org 
[lkml]   [2014]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: linux-next: Tree for Apr 1 (netfilter)
From
Hi David,

On Sun, Apr 6, 2014 at 5:31 PM, David Miller <davem@davemloft.net> wrote:
>> On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@davemloft.net> wrote:
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>> Date: Tue, 01 Apr 2014 11:34:15 -0700
>>>> on x86_64:
>>>>
>>>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>>>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>>>
>>>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>>>
>>> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
>>> sized array elements.
>>
>> Anyone with a suggestion?
>>
>> Please note this is now in Linus' tree, possibly crashing people's boxes...
>
> I took in the version of the fix I didn't like via Pablo for
> now.

Thank you!

Fixing ARRAY_SIZE() can still be done later, if possible.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvald


\
 
 \ /
  Last update: 2014-04-06 19:01    [W:0.087 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site