Messages in this thread | | | Date | Sun, 06 Apr 2014 14:00:10 -0500 | From | Joel Pelaez Jorge <> | Subject | Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning |
| |
El 06/04/14 13:49, Joe Perches escribió: > On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote: >> Fix a sparse warning, non static symbol is no declared as such. >> And fix a conflict with static function declared extern to include >> rtl_wx.h header. >> >> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: >> symbol 'r8192_wx_handlers_def' was not declared. Should it be static? >> >> Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com> >> --- >> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c >> b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c >> index 498995d..f17584d 100644 >> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c >> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c >> @@ -19,6 +19,7 @@ >> >> #include <linux/string.h> >> #include "rtl_core.h" >> +#include "rtl_wx.h" >> >> #define RATE_COUNT 12 >> static u32 rtl8192_rates[] = { >> @@ -1293,7 +1294,7 @@ static iw_handler r8192_private_handler[] = { >> (iw_handler)r8192_wx_get_PromiscuousMode, >> }; >> >> -static struct iw_statistics *r8192_get_wireless_stats(struct net_device >> *dev) >> +struct iw_statistics *r8192_get_wireless_stats(struct net_device *dev) >> { >> struct r8192_priv *priv = rtllib_priv(dev); >> struct rtllib_device *ieee = priv->rtllib; > > As far as I can tell, there's no reason this should > be declared in the .h file and it should stay static > and not be exposed at all. > > In the source "rtl_core.c" is possible to use the symbol r8192_get_wireless_stats, if WIRELESS_EXT has specifics values.
Although this scenario is unlikely to happen, is better prepare this code for it.
Also, a better way will be delete 'extern' reference to symbol in header file and source file. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |