Messages in this thread | | | Date | Fri, 4 Apr 2014 09:33:40 +0100 | From | Charles Keepax <> | Subject | Re: [PATCH 1/3] regulator: core: Add of_node_get to of_regulator_match |
| |
On Thu, Apr 03, 2014 at 10:50:27PM +0100, Mark Brown wrote: > On Thu, Apr 03, 2014 at 03:32:15PM +0100, Charles Keepax wrote: > > Currently, of_regulator_match does not increment the reference count of > > the of_nodes it takes new references to. This could cause the node > > pointer held to be invalid, by the time it is passed to the regulator > > core. This patchs adds an of_node_get when we copy each of_node pointer > > into the match structure. > > Applied all, thanks. You just made all users of of_regulator_match() > buggy - I'm assuming you're going to be fixing that! :P
Yeah I am on it, just wanted to make sure this was an acceptable approach before I went off doing loads of patches.
Thanks, Charles
| |