lkml.org 
[lkml]   [2014]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] i2c-designware: Mask interrupts during i2c controller enable
    On Fri, Apr 04, 2014 at 09:20:39PM +0300, Du, Wenkai wrote:
    > In current driver implementation, I2c controller is enabled, then
    > disabled every time inside i2c_dw_xfer. So I think the interrupt masking
    > should be done inside i2c_dw_xfer_init, where the controller is enabled.

    Interrupt masking is done already after each transaction.

    The problem here is that after reset, the interrupt mask register gets
    0x8ff value (HW default), which means that most of the interrupts are left
    unmasked.

    That is the reason why this only happens right after we resume from
    system sleep. Masking interrupts on that path fixes the problem.


    \
     
     \ /
      Last update: 2014-04-04 21:21    [W:8.454 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site