Messages in this thread | | | Date | Wed, 30 Apr 2014 18:34:02 -0700 | From | Mark Brown <> | Subject | Re: [PATCH] spi: Fix hung task timeout when initialization fails |
| |
On Wed, Apr 30, 2014 at 12:36:11PM +0200, Ricardo Ribalda Delgado wrote:
> Since "786235eeba0e1e85e5cbbb9f97d1087ad03dfa21 kthread: > make kthread_create() killable" kthread_run can be killed by the user, > ie, by killing modprobe.
> - flush_kthread_worker(&master->kworker); > - kthread_stop(master->kworker_task); > + if (!IS_ERR(master->kworker_task)) { > + flush_kthread_worker(&master->kworker); > + kthread_stop(master->kworker_task); > + }
How does this fix avoid racing with the task being killed? It will improve things but it doesn't look like a full fix.
Please don't include entire backtraces in commit messages, they're typically extremely long and don't really add anything - edited highlights are fine but try to keep it to the point. [unhandled content-type:application/pgp-signature] | |