lkml.org 
[lkml]   [2014]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lib/spinlock_debug: avoid one thread can not obtain the spinlock for a long time.
On Wed, Apr 30, 2014 at 06:17:48AM +0000, Wang, Xiaoming wrote:
> Dear Peter
> If we wait the end of loop as loops_per_jiffy.
> It may last more than 130s and local IRQ disabled at interval
> which may cause Hard LOCKUP. We break out in 1 second and
> dump the stack for debug.

Yeah, so? That makes shoddy engineering alright then?

So either fix the loops_per_jiffy thing, it is supposed to wait for 1
second after all, or explain why its broken and entirely replace it.

What you do not do is make a loop with 2 differently broken timeouts and
hope one works.


\
 
 \ /
  Last update: 2014-04-30 10:01    [W:0.082 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site