Messages in this thread | | | Date | Wed, 30 Apr 2014 17:07:50 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] DMA-API: Change dma_declare_coherent_memory() CPU address to phys_addr_t |
| |
On Wed, Apr 30, 2014 at 02:33:21PM -0600, Bjorn Helgaas wrote: > dma_declare_coherent_memory() takes two addresses for a region of memory: a > "bus_addr" and a "device_addr". I think the intent is that "bus_addr" is > the physical address a *CPU* would use to access the region, and > "device_addr" is the bus address the *device* would use to address the > region. > > Rename "bus_addr" to "phys_addr" and change its type to phys_addr_t.
Isn't this going to cause problems with the callers of this function? You aren't changing them...
greg k-h
| |