Messages in this thread | | | Date | Wed, 30 Apr 2014 08:41:43 +0200 | From | Robert Richter <> | Subject | Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities |
| |
On 18.04.14 20:53:23, Myron Stowe wrote: > From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> - start = reg & 0xffffff00; /* 39:16 on 31:8*/ > - start <<= 8; > - reg = read_pci_config(bus, slot, 1, 0x84 + (i << 3)); > + start = (reg & 0xffffff00UL) << 8; /* 39:16 on 31:8 */
I think this is not save anymore with respect to u32/u64 casting. The original was.
-Robert
| |