lkml.org 
[lkml]   [2014]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCHv2 1/3] phy: Add exynos-simple-phy driver
From
Hi Tomasz,

I have tested your patches for exynos5250 and 5420. Works fine. Are
you planning to post v3? If you want I can share hand with you for v3.

Regards,
Rahul Sharma

On 9 April 2014 17:17, Andreas Oberritter <obi@saftware.de> wrote:
> Hello Andrzej,
>
> On 09.04.2014 10:37, Andrzej Hajda wrote:
>>> +static int exynos_phy_probe(struct platform_device *pdev)
>>> +{
>>> + const struct of_device_id *of_id = of_match_device(
>>> + of_match_ptr(exynos_phy_of_match), &pdev->dev);
>>> + const u32 *offsets = of_id->data;
>>> + int count;
>>> + struct device *dev = &pdev->dev;
>>> + struct phy **phys;
>>> + struct resource *res;
>>> + void __iomem *regs;
>>> + int i;
>>> + struct phy_provider *phy_provider;
>>> +
>>> + /* count number of phys to create */
>>> + for (count = 0; offsets[count] != ~0; ++count)
>>> + ;
>>
>> count = ARRAY_SIZE(offsets) - 1;
>
> u32 *offsets is not an array.
>
> Regards,
> Andreas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


\
 
 \ /
  Last update: 2014-04-30 09:01    [W:0.095 / U:2.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site