Messages in this thread | | | Date | Wed, 30 Apr 2014 18:44:41 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 07/15] ARM: dts: kirkwood: consolidate common pinctrl settings |
| |
On Wed, Apr 30, 2014 at 10:42:36AM -0600, Jason Gunthorpe wrote: > On Wed, Apr 30, 2014 at 02:56:34PM +0200, Sebastian Hesselbarth wrote: > > All SoCs have the same pinctrl setting for NAND, UART0/1, SPI, TWSI0, > > and GBE1. Move it to the common pinctrl node that we now have. > > There are two possible choices for UART0, UART1, and SPI on kirkwood.. > > For instance I use this on my board: > > pmx_spi0: pmx-spi0 { > marvell,pins = "mpp7", "mpp10", "mpp11", "mpp12"; > marvell,function = "spi"; > }; > > vs > > > + > > + pmx_spi: pmx-spi { > > + marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3"; > > + marvell,function = "spi"; > > + }; > > It looks like all the boards in the kernel use the same choice, so it > makes some sense to consolidate, but I assume a board file can > override the marvell,pins?
Hi Jason
Yes, the board can override it, see patch 10/15 for an example.
Andrew
| |