lkml.org 
[lkml]   [2014]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations
Hi Roger,

On Wed, Apr 30, 2014 at 03:36:26PM +0300, Roger Quadros wrote:

> static int pixcir_i2c_ts_remove(struct i2c_client *client)
> @@ -198,10 +194,8 @@ static int pixcir_i2c_ts_remove(struct i2c_client *client)
>
> tsdata->exiting = true;
> mb();
> - free_irq(client->irq, tsdata);
>
> input_unregister_device(tsdata->input);

There is no need to call input_unregister_device for managed input
devices.

> - kfree(tsdata);
>
> return 0;
> }
> --
> 1.8.3.2
>

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2014-04-30 19:01    [W:0.060 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site