Messages in this thread | | | Subject | Re: [PATCH] [linux-next] [staging] rtl8821ae: fixed defined-not-used warning | From | Paul Bolle <> | Date | Wed, 30 Apr 2014 14:39:50 +0200 |
| |
On Wed, 2014-04-30 at 14:15 +0200, Jan Moskyto Matejka wrote: > --- a/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c > +++ b/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c > @@ -503,6 +503,7 @@ static void halbtc8192e2ant_querybt_info(struct btc_coexist *btcoexist) > btcoexist->btc_fill_h2c(btcoexist, 0x61, 1, h2c_parameter); > } > > +#if (BT_AUTO_REPORT_ONLY_8192E_2ANT != 0) > static bool halbtc8192e2ant_iswifi_status_changed(struct btc_coexist *btcoexist) > { > static bool pre_wifi_busy; > @@ -534,6 +535,7 @@ static bool halbtc8192e2ant_iswifi_status_changed(struct btc_coexist *btcoexist) > > return false; > } > +#endif > > static void halbtc8192e2ant_update_btlink_info(struct btc_coexist *btcoexist) > {
The output of git grep BT_AUTO_REPORT_ONLY_8192E_2ANT next-20140430
is next-20140430:drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:#if (BT_AUTO_REPORT_ONLY_8192E_2ANT == 1) next-20140430:drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:#if (BT_AUTO_REPORT_ONLY_8192E_2ANT == 0) next-20140430:drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:#if (BT_AUTO_REPORT_ONLY_8192E_2ANT == 0) next-20140430:drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.h:#define BT_AUTO_REPORT_ONLY_8192E_2ANT 0
So it seems that some trivial cleaning up is possible. Ie, drop the #define and drop the three tests that are either always true or always false. Is there a reason not to do that cleaning up?
Paul Bolle
| |