Messages in this thread | | | Date | Thu, 3 Apr 2014 11:32:30 +0200 | From | Daniel Vetter <> | Subject | Re: [Intel-gfx] [PATCH] drm/i915: fix command parser debug print format mismatches |
| |
On Wed, Apr 02, 2014 at 08:26:23AM -0700, Randy Dunlap wrote: > On 04/02/2014 01:24 AM, Jani Nikula wrote: > > Drop the cast from the pointer diff to fix: > > > > drivers/gpu/drm/i915/i915_cmd_parser.c:405:4: warning: format '%td' expects > > argument of type 'ptrdiff_t', but argument 5 has type 'long unsigned int' > > [-Wformat] > > > > While at it, use %u for u32. > > > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > > > --- > > > > Randy, try as I might, I wasn't able to coerce gcc to spit out that > > warning. Please enlighten me! (Does this fix the warn?) > > Yes, it does. Thanks. > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
Maybe I'm blind, but I think the recent refactoring patch fixed this. Can someone please double-check? I always get confused with printf formats ;-)
Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
| |