Messages in this thread | | | Date | Thu, 3 Apr 2014 12:04:51 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning |
| |
On Thu, Mar 27, 2014 at 08:28:44PM -0700, Jimmy Li wrote: > You are right, I found that variable buf also don't make sense here, > maybe this could be more clear. > > param = kzalloc(sizeof(struct viawget_wpa_param), GFP_KERNEL); > if (param == NULL) > return -ENOMEM; > > removing two unnecessary variable, buf and blen. > > In this situation, I should send a new patch v2 for it base on the > previous path? or send a new patch include all changes?
We throw away the original patch and you send a v2. Use the subject:
[PATCH v2] drivers/staging/vt6655/iwctl.c fix a sparse warning
Under the Signed-off-by line put: Signed-off-by: you --- v2: additional cleanups as well.
regards, dan carpenter
| |