Messages in this thread | | | Date | Thu, 3 Apr 2014 00:49:30 -0400 | From | Dave Jones <> | Subject | Re: powerpc/powernv: Enable reading and updating of system parameters |
| |
On Wed, Apr 02, 2014 at 08:54:01PM +0000, Linux Kernel wrote: > Gitweb: http://git.kernel.org/linus/;a=commit;h=4029cd66545f0a45258eda5313b7559bfeaaaae4 > Commit: 4029cd66545f0a45258eda5313b7559bfeaaaae4 > Parent: 8d724823220862ce289be3b50119235e03537597 > Author: Neelesh Gupta <neelegup@linux.vnet.ibm.com> > AuthorDate: Fri Mar 7 11:02:09 2014 +0530 > Committer: Benjamin Herrenschmidt <benh@kernel.crashing.org> > CommitDate: Mon Mar 24 09:47:30 2014 +1100 > > powerpc/powernv: Enable reading and updating of system parameters > > This patch enables reading and updating of system parameters through > OPAL call. > ...
> + /* If the parameter is read-only or read-write */ > + switch (perm[i] & 3) { > + case OPAL_SYSPARAM_READ: > + attr[i].kobj_attr.attr.mode = S_IRUGO; > + break; > + case OPAL_SYSPARAM_WRITE: > + attr[i].kobj_attr.attr.mode = S_IWUGO; > + break; > + case OPAL_SYSPARAM_RW: > + attr[i].kobj_attr.attr.mode = S_IRUGO | S_IWUGO; > + break; > + default: > + break; Is world-writable really appropriate for this ?
Dave
| |