Messages in this thread | | | From | Richard Genoud <> | Date | Thu, 3 Apr 2014 17:46:30 +0200 | Subject | Re: [PATCH] rt2x00: BUG: remove double loop on REGISTER_BUSY_COUNT |
| |
2014-04-03 17:37 GMT+02:00 Jakub Kiciński <moorray3@wp.pl>: > On Thu, 3 Apr 2014 16:12:07 +0200, Richard Genoud wrote: >> rt2x00usb_register_read_lock() calls rt2x00usb_vendor_req_buff_lock() >> that calls rt2x00usb_vendor_request() which is already looping up to >> REGISTER_BUSY_COUNT times. >> >> So this loop is not needed. > > Not true. rt2x00usb_vendor_request() busy-waits for usb_control_msg() > to succeed, rt2x00usb_register_read_lock() busy-waits for the register > field itself to become 0. > > Also, how would this be a BUG?
Ok, you're right. Just forget about this patch...
Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |