Messages in this thread Patch in this message | | | Date | Thu, 3 Apr 2014 10:21:34 +0300 | From | Dan Carpenter <> | Subject | [patch] irqchip/irq-crossbar: not allocating enough memory |
| |
We are allocating the size of a pointer and not the size of the data. This will lead to memory corruption.
There isn't actually a "cb_device" struct, btw. The code is only able to compile because GCC knows that all pointers are the same size.
Fixes: 96ca848ef7ea ('DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index fc817d2..3d15d16 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers/irqchip/irq-crossbar.c @@ -107,7 +107,7 @@ static int __init crossbar_of_init(struct device_node *node) int i, size, max, reserved = 0, entry; const __be32 *irqsr; - cb = kzalloc(sizeof(struct cb_device *), GFP_KERNEL); + cb = kzalloc(sizeof(*cb), GFP_KERNEL); if (!cb) return -ENOMEM;
| |