Messages in this thread | | | Date | Thu, 3 Apr 2014 14:51:09 -0500 | Subject | Re: [PATCH v4 1/3] i2c: cadence: Document device tree bindings | From | Rob Herring <> |
| |
On Thu, Apr 3, 2014 at 12:59 PM, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote: > Add device tree binding documentation for the Cadence I2C controller. > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > --- > > Changes in v4: > - moved adding DT docs into this dedicated patch > > Changes in v3: None > Changes in v2: None > > --- > .../devicetree/bindings/i2c/i2c-cadence.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-cadence.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-cadence.txt b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt > new file mode 100644 > index 000000000000..685adf513111 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt > @@ -0,0 +1,21 @@ > +Binding for the Cadence I2C controller > + > +Required properties: > + compatible: Compatibility string. Must be 'cdns,i2c-r1p10'. > + clocks: From common clock bindings. Phandle to input clock. > + > +Optional properties: > + clock-frequency: Desired operating frequency, in Hz, of the bus (actual may > + be lower). Defaults to 400000 if not specified.
Since not all devices support 400kHz, I would prefer that the default be 100kHz. Also, it would be good if what speed the default is consistent across i2c drivers.
Rob
| |