Messages in this thread | | | Date | Thu, 3 Apr 2014 20:52:52 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging : panel : fix checkpatch warnings (linux-next) |
| |
On Thu, Apr 03, 2014 at 06:59:09PM +0200, armand.bastien@laposte.net wrote: > This patch fixes "Missing a blank line after declarations" checkpatch warning in panel.c. > > > Signed-off-by: "Bastien Armand <armand.bastien@laposte.net>"
Fix your email client to use the proper From header. The signed-off-by format is wrong as well (extra quotes). The subject should be:
[PATCH] staging: panel: add blank lines after declarations
The original had extra space characters. Don't put "(linux-next)" in the permanent log. Be as specific as you can in roughly 52 characters.
Otherwise it looks ok.
regards, dan carpenter
| |