lkml.org 
[lkml]   [2014]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] drivers/staging/vt6655/iwctl.c fix a sparse warning
On Fri, Apr 04, 2014 at 12:32:29AM +0800, Jimmy Li wrote:
> Signed-off-by: Jimmy Li <coder.liss@gmail.com>

You dropped the commit message which said which sparse warnings were
fixed. It should say something about the other cleanups as well. Also
the subject prefix isn't right. Use:

[PATCH v3] Staging: vt6655: iwctl.c: fix a sparse warning

Or something. "drivers/" doesn't add any information.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-04-03 20:01    [W:0.034 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site