Messages in this thread | | | Date | Thu, 03 Apr 2014 08:13:46 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 2/2] ttyprintk: Allow built as a module |
| |
At Wed, 2 Apr 2014 12:32:22 -0700, Greg Kroah-Hartman wrote: > > On Wed, Apr 02, 2014 at 12:29:42PM +0200, Takashi Iwai wrote: > > The driver is well written to be used as a module, just the exit call > > is missing. > > > > Signed-off-by: Takashi Iwai <tiwai@suse.de> > > --- > > drivers/char/Kconfig | 2 +- > > drivers/char/ttyprintk.c | 13 ++++++++++++- > > 2 files changed, 13 insertions(+), 2 deletions(-) > > There was some reason we didn't do this back when the code was accepted, > but I really can't remember why. > > If you have tested this out, I don't have any objections to taking these > patches, thanks.
The module worked fine with my quick tests (load/unload/feed something via /dev/ttyprintk), at least. But it'd be helpful if anyone remembers and clarifies.
thanks,
Takashi
| |