Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 3/4] perf, callchain: Add generic report parse callchain callback function | Date | Thu, 03 Apr 2014 14:57:32 +0900 |
| |
On Mon, 24 Mar 2014 15:32:56 -0400, Don Zickus wrote: > This takes the parse_callchain_opt function and copies it into the > callchain.c file. Now the c2c tool can use it too without duplicating. > > Signed-off-by: Don Zickus <dzickus@redhat.com> > --- > tools/perf/util/callchain.c | 83 +++++++++++++++++++++++++++++++++++++++++++++ > tools/perf/util/callchain.h | 1 + > 2 files changed, 84 insertions(+) > > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c > index 8d9db45..2320678 100644 > --- a/tools/perf/util/callchain.c > +++ b/tools/perf/util/callchain.c > @@ -25,6 +25,89 @@ > > __thread struct callchain_cursor callchain_cursor; > > +int > +report_parse_callchain_opt(const char *arg)
As it eliminated any dependency to the report code, the name can omit 'report' as well.
Thanks, Namhyung
| |