Messages in this thread | | | Date | Tue, 29 Apr 2014 14:55:27 -0400 | From | Jason Cooper <> | Subject | Re: [PATCH 1/5] ARM: defconfigs: add MTD_SPI_NOR (new dependency for M25P80) |
| |
On Tue, Apr 29, 2014 at 03:28:15PM -0300, Ezequiel Garcia wrote: > On Apr 29, Jason Cooper wrote: > > On Tue, Apr 29, 2014 at 02:22:27PM -0300, Ezequiel Garcia wrote: > > > On Apr 25, Stephen Warren wrote: > > > > On 04/17/2014 01:21 AM, Brian Norris wrote: > > > > > These defconfigs contain the CONFIG_M25P80 symbol, which is now > > > > > dependent on the MTD_SPI_NOR symbol. Add CONFIG_MTD_SPI_NOR to the > > > > > relevant defconfigs. > > > > > > > > > > At the same time, drop the now-nonexistent CONFIG_MTD_CHAR symbol. > > > > Excuse my ignorance of the history of this bug, but shouldn't this be > > solved in the Kconfig logic? Since when do we solve config symbol > > dependency bugs in the defconfigs? > > > > Long story short: it was decided that select'ing this new symbol was not > appropriate. Instead, it must be explicitly selected by the user, hence > the defconfig fix. > > The full story: https://lkml.org/lkml/2014/4/17/45
ahhh, it already depend's on MTD_SPI_NOR in Kconfig
http://git.infradead.org/l2-mtd.git/blobdiff/254592db612aeb55d80399a04995b68f7da48c99..e43b20619bdb6c851dd7b49cbd15e52875a785d4:/drivers/mtd/devices/Kconfig
ok, now it makes sense.
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
| |