lkml.org 
[lkml]   [2014]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv3 4/5] Input: tsc2005: add DT support
    On Sat 2014-04-26 01:56:18, Sebastian Reichel wrote:
    > This adds DT support to the tsc2005 touchscreen
    > driver.
    >
    > Signed-off-by: Sebastian Reichel <sre@kernel.org>

    > @@ -100,6 +102,11 @@
    > TSC2005_CFR2_AVG_7)
    >
    > #define MAX_12BIT 0xfff
    > +#define TSC2005_DEF_X_FUZZ 4
    > +#define TSC2005_DEF_Y_FUZZ 8
    > +#define TSC2005_DEF_P_FUZZ 2
    > +#define TSC2005_DEF_RESISTOR 280
    >

    IMO using defines insteaed of plain numbers does not help readability much,
    but ....

    Reviewed-by: Pavel Machek <pavel@ucw.cz>


    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2014-04-29 13:21    [W:2.254 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site