Messages in this thread | | | Date | Mon, 28 Apr 2014 17:17:21 +0200 | From | Jan Moskyto Matejka <> | Subject | Re: Updated asmlinkage patch v2 |
| |
> On Tue, Apr 1, 2014 at 2:40 PM, Andi Kleen <andi@firstfloor.org> wrote: > > > > Did some basic sanity checks with LTO and everything > > works (still need the three other LTO patches to build) > > Ok, this series looks much better. Thanks,
It seems this series hasn't made it to the torvalds tree yet so the compiler still issues complaints about __visible static functions. Should I bring a patch removing the "static" from asmlinkage-annotated functions, or is this patch the better way? Or have I missed something?
BTW some of the functions have already lost their asmlinkage, see commit 8783dd3a37a5853689e1a8fa728827a50905b912 ("irqchip: Remove asmlinkage from static functions") in torvalds tree and also recent thread https://lkml.org/lkml/2014/4/16/453 ("[PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions"), both of them because "it issues warnings".
MQ [unhandled content-type:application/pgp-signature] | |