Messages in this thread | | | Date | Mon, 28 Apr 2014 23:37:32 +0800 | From | Huang Shijie <> | Subject | Re: [PATCH V3] Add support for flag status register on Micron chips. |
| |
On Mon, Apr 28, 2014 at 09:22:58AM -0500, Graham Moore wrote: > On Mon, Apr 28, 2014 at 2:06 AM, Huang Shijie <b32955@freescale.com> wrote: > > On Mon, Apr 28, 2014 at 07:06:17AM +0200, Marek Vasut wrote: > >> > >> Two things competing over the same pointer looks misdesigned to me. I will need > >> to dig into this one more time ... > > Please refer to the code for NAND chip, the nand_get_flash_type() : > > > > ----------------------------------------------------------- > > /* Do not replace user supplied command function! */ > > if (mtd->writesize > 512 && chip->cmdfunc == nand_command) > > chip->cmdfunc = nand_command_lp; > > ----------------------------------------------------------- > > > > It uses the same logic: > > " Do not replace user supplied command function!" > > > > thanks > > Huang Shijie > > I would like to set the @wait_till_ready in m25p80.c, because the > USE_FSR flag is only for Micron chips. But the m25p80 driver doesn't m25p80.c is not the right place.
we should put these code in the spi-nor.c
thanks Huang Shijie
| |