lkml.org 
[lkml]   [2014]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 29/47] staging/lustre/lnet: lnet: fix issues found by Klocwork Insight tool
On Sun, Apr 27, 2014 at 01:06:53PM -0400, Oleg Drokin wrote:
> From: Dmitry Eremin <dmitry.eremin@intel.com>
>
> Null pointer 'cp' that comes from line 2544 may be dereferenced
> at line 2618.
>
> Pointer 'ni' checked for NULL at line 1569 may be passed to
> function and may be dereferenced there by passing argument 1 to
> function 'lnet_ni_notify_locked' at line 1621.
>
> Null pointer 'best_iface' that comes from line 802 may be
> dereferenced at line 832.
>
> Buffer overflow of string buffer due to non null terminated string.
>
> Pointer 'tsc' returned from call to function 'sfw_find_test_case'
> at line 571 may be NULL and will be dereferenced at line 572.
>
> Local variable 'hash' is never used.

Each kernel patch should only do one thing, not 6 different things.
Please break this up into 6 different patches.

thanks,

greg k-h


\
 
 \ /
  Last update: 2014-05-01 06:21    [W:2.411 / U:2.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site