Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core | Date | Fri, 25 Apr 2014 16:44:58 -0700 |
| |
Geert Uytterhoeven <geert+renesas@glider.be> writes:
> When adding a device from DT, check if its clocks are suitable for Runtime > PM, and register them with the PM core. > If Runtime PM is disabled, just enable the clock. > > This allows the PM core to automatically manage gate clocks of devices for > Runtime PM.
...unless the device is already in an existing pm_domain, right?
I like this approach, and it extends nicely what we already do on platforms using drivers/base/power/clock_ops.c into DT land.
My only concern is how this will interact if it's used along with devices that have existing pm_domains. I don't have any specific concerns (yet, because it's Friday, and my brain is turing off), but it just made me wonder if this will be potentially confusing.
Also...
[...]
> +static int of_clk_register(struct device *dev, struct clk *clk) > +{ > + int error; > + > + if (!dev->pm_domain) { > + error = pm_clk_create(dev); > + if (error) > + return error; > + > + dev->pm_domain = &of_clk_pm_domain; > + } > + > + dev_dbg(dev, "Setting up clock for runtime PM management\n"); > + return pm_clk_add_clk(dev, clk);
I would've expected these 2 lines to be inside the pm_domain check.
What's the reason for doing the pm_clk_add() when the pm_domain isn't going to be used? I suppose it's harmless, but it's a bit confusing.
Kevin
| |